[Lldb-commits] [PATCH] D11378: Xfail TestGdbRemoteAbort for Android API <= 16.

Tamas Berghammer tberghammer at google.com
Tue Jul 21 02:29:31 PDT 2015


tberghammer added inline comments.

================
Comment at: test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py:36
@@ -35,3 +35,3 @@
     @dwarf_test
-    @skipIfTargetAndroid(api_levels=[16]) # abort() on API 16 raises SIGSEGV!
+    @expectedFailureAndroid(api_levels=range(9, 16 + 1)) # abort() below API 16 raises SIGSEGV!
     def test_inferior_abort_received_llgs_dwarf(self):
----------------
* For me "abort() below API 16 raises SIGSEGV" means it already works on API-16, but the XFAIL range specifies it isn't. Can you clarify it? (If I misunderstand the comment then please ignore this.)
* Even though we most likely never run the test suit against API level less then 9 I think it is cleaner if you specify the XFAIL for API range [1, 16] (or range [0, 16])


http://reviews.llvm.org/D11378







More information about the lldb-commits mailing list