[Lldb-commits] [PATCH] D11173: Compile and run objc tests in TestObjCBuiltinTypes.py as objc instead of c++.

Dawn Perchik dawn+llvm at burble.org
Mon Jul 20 22:35:15 PDT 2015


dawn abandoned this revision.
dawn added a comment.

In http://reviews.llvm.org/D11173#208329, @spyffe wrote:

> This looks like it's actually testing the wrong thing… the point is that the expression parser is in ObjC++ mode at all times and we want to make sure that we aren't misinterpreting something that happens to have the name "id" from C++ as something that's an ObjC id.


I see.

> I'm concerned about the implicit suggestion that we not be in ObjC++ mode at all times.


I ran into this when I wanted to have the default language be that of the selected frame, but folks prefer an option for that, so this test case will still work as is.

Thanks for your review.


Repository:
  rL LLVM

http://reviews.llvm.org/D11173







More information about the lldb-commits mailing list