[Lldb-commits] [PATCH] D11296: [LLGS] Get rid of the stdio forwarding thread

[Oleksiy Vyalov]

ovyalov accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:970
@@ +969,3 @@
+                log->Printf("GDBRemoteCommunicationServerLLGS::%s Stopping stdio forwarding as communication returned status %d (error: %s)", __FUNCTION__, status, error.AsCString());
+            m_stdio_handle_up.reset();
+            return;
----------------
If eventually lldb-server will be fully single-threaded then then it's ok to keep MainLoop as-is - since anyway monitor will be part of main thread.

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1065
@@ -1053,2 +1064,3 @@
 
-    FlushInferiorOutput ();
+    // Stop forwarding stdio
+    {
----------------
You may wrap it up into a separate function since there are 2 usages of such code.


http://reviews.llvm.org/D11296