[Lldb-commits] [PATCH] D11127: [CMake] Don't build Interpreter unittest if python is disabled
zturner at google.com
Sat Jul 18 06:54:55 PDT 2015
Hi, I have been gone for the past 5 weeks, but I have an unfinished patch
which will make Interpreter independent from Python so you can build the
interpreter unittests regardless of your setting of LLDB_DISABLE_PYTHON.
This actually makes more sense, because even without my patch Python is
only a small subset of the functionality contained in Interpreter, and the
other stuff should still be able to be unit tested.
On Tue, Jul 14, 2015 at 1:52 AM Pavel Labath <labath at google.com> wrote:
> labath added a comment.
> In http://reviews.llvm.org/D11127#203885, @loladiro wrote:
> > I was getting a link error with python. I just assumed it was required
> since it was explicitly linked. Do you mean remove it entirely, independent
> of whether LLDB_DISABLE_PYTHON is set, or just in that case?
> I am pretty sure that the dependency is required if the whole lldb is
> built with python. I am proposing we make the just the dependency on python
> conditional on the LLDB_DISABLE_PYTHON setting. Could you check if that
> works for you?
> rL LLVM
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits