[Lldb-commits] [PATCH] D11119: Parse breakpoint expressions using the language of the frame's CU.

[Jim Ingham]

That sounds fine, except you shouldn't call the option "expr-language" because we expr is the common abbreviation for the "expression" command, but the breakpoint specifications are not in general expressions.  In fact, the only breakpoint specifier that is an expression: --address would NOT take this option...  So that's a confusing name.

Since you are only going to add the language options to versions of breakpoint set that take some form of identifier (--name, --method --base-name) maybe --identifier-language would be better?

Jim


> On Jul 15, 2015, at 2:17 AM, Dawn Perchik <dawn+llvm at burble.org> wrote:
> 
> dawn added a comment.
> 
> I will add breakpoint option:
> 
>  breakpoint set --expr-language <lang> <expr>
> 
> and default option:
> 
>  settings set target.expr-language <lang>
> 
> and submit revised patch.  Sound good?
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D11119
> 
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits