[Lldb-commits] [PATCH] D11187: Add jThreadsInfo support to lldb-server

[Oleksiy Vyalov]

ovyalov added inline comments.

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:470
@@ +469,3 @@
+
+    static constexpr uint32_t k_expedited_registers[] = {
+        LLDB_REGNUM_GENERIC_PC, LLDB_REGNUM_GENERIC_SP, LLDB_REGNUM_GENERIC_FP, LLDB_REGNUM_GENERIC_RA
----------------
s/constexpr/const for compatibility with Visual Studio?

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:471
@@ +470,3 @@
+    static constexpr uint32_t k_expedited_registers[] = {
+        LLDB_REGNUM_GENERIC_PC, LLDB_REGNUM_GENERIC_SP, LLDB_REGNUM_GENERIC_FP, LLDB_REGNUM_GENERIC_RA
+    };
----------------
What do you think about having #ifdef/#else branching to cover both of them - full set of registers and pruned?
I'd rather keep new functionality and optimizations in separate CLs - for example, if later, down the road we'll realize that have to send a full set of registers then only a CL that enables pruned set of registers should be reverted.

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:521
@@ +520,3 @@
+        return "breakpoint";
+        break;
+    case eStopReasonWatchpoint:
----------------
No need to have 'break' here.


http://reviews.llvm.org/D11187