[Lldb-commits] [lldb] r242182 - Fix temp port file path generation in lldb-platform.

Oleksiy Vyalov ovyalov at google.com
Tue Jul 14 11:54:52 PDT 2015


Author: ovyalov
Date: Tue Jul 14 13:54:52 2015
New Revision: 242182

URL: http://llvm.org/viewvc/llvm-project?rev=242182&view=rev
Log:
Fix temp port file path generation in lldb-platform.

http://reviews.llvm.org/D11152


Modified:
    lldb/trunk/tools/lldb-server/lldb-platform.cpp

Modified: lldb/trunk/tools/lldb-server/lldb-platform.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/lldb-platform.cpp?rev=242182&r1=242181&r2=242182&view=diff
==============================================================================
--- lldb/trunk/tools/lldb-server/lldb-platform.cpp (original)
+++ lldb/trunk/tools/lldb-server/lldb-platform.cpp Tue Jul 14 13:54:52 2015
@@ -102,15 +102,14 @@ display_usage (const char *progname, con
 static Error
 save_port_to_file(const uint16_t port, const FileSpec &port_file_spec)
 {
-    const ConstString& port_file_dir = port_file_spec.GetDirectory();
-    auto error = FileSystem::MakeDirectory(
-        FileSpec(port_file_dir.AsCString(), false), eFilePermissionsDirectoryDefault);
+    FileSpec temp_file_spec(port_file_spec.GetDirectory().AsCString(), false);
+    auto error = FileSystem::MakeDirectory(temp_file_spec, eFilePermissionsDirectoryDefault);
     if (error.Fail())
-       return Error("Failed to create directory %s: %s", port_file_dir.AsCString(), error.AsCString());
+       return Error("Failed to create directory %s: %s", temp_file_spec.GetCString(), error.AsCString());
 
     llvm::SmallString<PATH_MAX> temp_file_path;
-    auto err_code = llvm::sys::fs::createTemporaryFile(
-        port_file_spec.GetPath().c_str(), "", temp_file_path);
+    temp_file_spec.AppendPathComponent("port-file.%%%%%%");
+    auto err_code = llvm::sys::fs::createUniqueFile(temp_file_spec.GetCString(), temp_file_path);
     if (err_code)
         return Error("Failed to create temp file: %s", err_code.message().c_str());
 





More information about the lldb-commits mailing list