[Lldb-commits] [PATCH] D11154: [Makefiles] Align library names with CMake build

Pavel Labath labath at google.com
Tue Jul 14 01:49:19 PDT 2015

labath added a comment.

Looks simple enough. I just have one question below.

Also, I don't feel entirely comfortable reviewing makefile changes as I don't use that build on a regular basis. If there is someone here who uses makefile builds and would like to take charge of this (and future) changes, then please step in.

Comment at: source/Host/Makefile:28
@@ -21,3 +27,3 @@
 ifeq ($(HOST_OS),Linux)
-DIRS += posix
-DIRS += linux
+$(eval $(call DIR_SOURCES,posix))
+$(eval $(call DIR_SOURCES,linux))
Why are some of these using `$(eval)` and others `$(eval $(call))` syntax? If there is no difference, we should unify them. If there is, let's put a comment explaining why.



More information about the lldb-commits mailing list