[Lldb-commits] [PATCH] D11135: Avoid dependency on uuid.h in MacOSXDYLD

Pavel Labath labath at google.com
Mon Jul 13 03:04:46 PDT 2015

labath created this revision.
labath added a reviewer: jasonmolenda.
labath added a subscriber: lldb-commits.

r241964 has added a dependency on uuid.h, which (on linux at least) necessitates instalation of a
new package. Since the only thing we need from that file is uuid_t (and this is already defined
in UuidCompatibility.h), we can avoid this dependency by making this include __APPLE__ specific.
If in future, we need more from this library, we can revisit this decision.



Index: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
--- source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
+++ source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
@@ -7,8 +7,6 @@
-#include <uuid/uuid.h>
 #include "lldb/Breakpoint/StoppointCallbackContext.h"
 #include "lldb/Core/DataBuffer.h"
 #include "lldb/Core/DataBufferHeap.h"
@@ -41,6 +39,8 @@
 #ifndef __APPLE__
 #include "Utility/UuidCompatibility.h"
+#include <uuid/uuid.h>
 using namespace lldb;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11135.29543.patch
Type: text/x-patch
Size: 692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150713/d3981038/attachment.bin>

More information about the lldb-commits mailing list