[Lldb-commits] [lldb] r241919 - Don't try to make a pseudo terminal if we are launching in a separate terminal, it causes a deadlock when debugging because we create a PTY and yet it isn't hooked up to anything on the slave side.

[Greg Clayton]

Author: gclayton
Date: Fri Jul 10 13:04:46 2015
New Revision: 241919

URL: http://llvm.org/viewvc/llvm-project?rev=241919&view=rev
Log:
Don't try to make a pseudo terminal if we are launching in a separate terminal, it causes a deadlock when debugging because we create a PTY and yet it isn't hooked up to anything on the slave side.


Modified:
    lldb/trunk/source/Target/ProcessLaunchInfo.cpp

Modified: lldb/trunk/source/Target/ProcessLaunchInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ProcessLaunchInfo.cpp?rev=241919&r1=241918&r2=241919&view=diff
==============================================================================
--- lldb/trunk/source/Target/ProcessLaunchInfo.cpp (original)
+++ lldb/trunk/source/Target/ProcessLaunchInfo.cpp Fri Jul 10 13:04:46 2015
@@ -284,6 +284,13 @@ ProcessLaunchInfo::FinalizeFileActions (
             log->Printf ("ProcessLaunchInfo::%s at least one of stdin/stdout/stderr was not set, evaluating default handling",
                          __FUNCTION__);
 
+        if (m_flags.Test(eLaunchFlagLaunchInTTY))
+        {
+            // Do nothing, if we are launching in a remote terminal
+            // no file actions should be done at all.
+            return;
+        }
+
         if (m_flags.Test(eLaunchFlagDisableSTDIO))
         {
             if (log)