[Lldb-commits] [PATCH] D11094: Refactor Unix signals.

[Chaoren Lin]

chaoren added a comment.

Tested on Linux (local and remote). Very likely broken on other platform (will test later).

Some thoughts:

1. Is it worth the effort to make Platform::GetUnixSignals const? Same thing with most (all?) of the Get* methods in PlatformRemoteGDBServer. I don't know if we should bother with const-correctness of remote protocols.
2. *Signals.{h,cpp} should probably be moved out of Process/Utility. But where?
3. Are Should{Suppress,Stop,Notify} per process properties or general properties of the signals. If it's per process, each process will need its own copy (which we didn't have before).


http://reviews.llvm.org/D11094