[Lldb-commits] [PATCH] D10744: Fix demangling of names if required by language

[Greg Clayton]

clayborg added a comment.

Please abandon this change and modify the following function after updating to my partial fix that plumbs all the code to be able to supply the language:

  % svn commit
  Sending        include/lldb/Core/Mangled.h
  Sending        include/lldb/Symbol/Function.h
  Sending        include/lldb/Symbol/Symbol.h
  Sending        include/lldb/Symbol/Variable.h
  Sending        source/API/SBBlock.cpp
  Sending        source/API/SBFrame.cpp
  Sending        source/API/SBFunction.cpp
  Sending        source/API/SBSymbol.cpp
  Sending        source/Breakpoint/BreakpointLocation.cpp
  Sending        source/Core/FormatEntity.cpp
  Sending        source/Core/Mangled.cpp
  Sending        source/Expression/IRExecutionUnit.cpp
  Sending        source/Expression/IRForTarget.cpp
  Sending        source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
  Sending        source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
  Sending        source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
  Sending        source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
  Sending        source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
  Sending        source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  Sending        source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
  Sending        source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  Sending        source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
  Sending        source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp
  Sending        source/Symbol/Function.cpp
  Sending        source/Symbol/Symbol.cpp
  Sending        source/Symbol/SymbolContext.cpp
  Sending        source/Symbol/Symtab.cpp
  Sending        source/Symbol/Variable.cpp
  Sending        source/Target/ThreadPlanStepOverRange.cpp
  Transmitting file data .............................
  Committed revision 241751.

After this you will need to modify the following function:

  const ConstString&
  Mangled::GetDemangledName (lldb::LanguageType language) const

To check if the language is pascal or java and do your fixups on it... You will need to store the pascal demanglings in a thread safe side table of ConstString to ConstString objects. Probably safe to just make a global table in Mangled.cpp that is protected by a mutex.


Repository:
  rL LLVM

http://reviews.llvm.org/D10744