[Lldb-commits] [PATCH] D10932: Improve UnwindLLDB with better detection for unwinding failures

[Jason Molenda]

jasonmolenda accepted this revision.

This revision is now accepted and ready to land.

I'm fine with trying this approach. These heuristics for falling back to alternate unwind methods are tricky to get right; often the best approach is to live on them for a bit and pay close attention to the unwinder in complicated unwind situations.

The only question I have about the patch is the  UnwindLLDB::CursorSP UnwindLLDB::GetOneMoreFrame (ABI* abi) method - you have 'return nullptr;' as a shortcut in a few places.  Is that safe?  Normally in a function that returns a shared pointer we'll write 'return CursorSP();' for this. I'm sure the nullptr gets converted to an empty shared pointer via a copy constructor, or something like that.  I'm fine with coding it this way, just wanted to check if anyone knows it's OK.


http://reviews.llvm.org/D10932