[Lldb-commits] [PATCH] D10906: Fix type signature for CMIUtilString::IsAllValidAlphaAndNumeric.This should take a "const char*" not a "char &".
Ilia K
ki.stfu at gmail.com
Thu Jul 2 22:42:16 PDT 2015
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: tools/lldb-mi/MIUtilString.cpp:489-491
@@ -488,6 +488,5 @@
- MIchar *pPtr = const_cast<MIchar *>(&vrText);
- for (MIuint i = 0; i < len; i++, pPtr++)
+ for (MIuint i = 0; i < len; i++, vpText++)
{
- const MIchar c = *pPtr;
+ const MIchar c = *vpText;
if (::isalnum((int)c) == 0)
----------------
a bit weird. may be the following is better?
```
for (MIuint i = 0; i < len; ++i)
{
const MIchar c = vpText[i];
[...]
```
http://reviews.llvm.org/D10906
More information about the lldb-commits
mailing list