[Lldb-commits] [PATCH] D10887: Use accept instead of accept4 for Android.

[Oleksiy Vyalov]

ovyalov added a subscriber: ovyalov.
ovyalov added a comment.

Potentially, there is no one size fits all solution.
Since statically linked binaries pose a significant threat due their incompatibility we might use dynamic linkage of lldb-server for majority of devices.
If there is need for hotfix which covers specific configuration - create a custom build of statically linked lldb-server which includes patches for affected platform and is built by toolchain for this platform. The same pattern may be applicable for devices which don't support -pie - like API-9.  
Such split will increase size of package that user has to download - to mitigate this we may download lldb components on-demand when user knows which api level is needed.

Zach sometimes ago proposed to split Socket.cpp into platform-specific pieces to reduce conditional compilation nesting - like PosixSocket.cpp, WindowsSocket.cpp,.. This idea can be taken further with finer granularity - AndroidSocket.cpp with some specialization on api level. But I'm not sure that in this particular case we need such workaround.


http://reviews.llvm.org/D10887