[Lldb-commits] [PATCH] D10887: Use accept instead of accept4 for Android.

[Chaoren Lin]

For reference, the gdbserver binary currently in the toolchain is
statically linked.

Using a shim results in about a 5M increase in the lldb-server binary
because of the need to export all symbols dynamically. And still has those
two bugs (which would be in the system libs, if linked dynamically).
On Jul 2, 2015 08:32, "Pavel Labath" <labath at google.com> wrote:

> labath added a comment.
>
> In http://reviews.llvm.org/D10887#198515, @chaoren wrote:
>
> > - b.android.com/178448
> > - pthread_sigmask doesn't work at all in the older toolchains
> >
> >   The only possible problems I can see right now are missing syscalls,
> and we can easily get a diff of those between API 21 and API 9.
>
>
> The sentence "in general, statically linked binaries are compatible with
> neither older nor newer releases, especially where networking is concerned"
> from the bug leads me to believe that we should reconsider the static
> linking approach. I would normally expect these to be at least forward
> compatible, but if they don't guarantee even that, I think we should go
> back to the idea of using a non-pie shim process to load the lldb-server on
> old devices. Otherwise, we can encounter subtle and annoying breakages,
> which I would prefer to avoid.
>
>
> http://reviews.llvm.org/D10887
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150702/2673ea1a/attachment.html>