[Lldb-commits] [PATCH] Add new bugreport command to lldb
Pavel Labath
labath at google.com
Wed Jul 1 05:44:13 PDT 2015
================
Comment at: source/Commands/CommandObjectBugreport.cpp:88
@@ +87,3 @@
+
+ uint32_t open_options = File::eOpenOptionWrite | File::eOpenOptionCanCreate;
+ const bool append = m_outfile_options.GetAppend().GetCurrentValue();
----------------
In no-append mode, you will start overwriting the file without first erasing it's contents. This leads to funny-looking files and is a pretty useless mode. I recommend setting eOpenOptionAppend unconditionally and adding eOpenOptionTruncate if `--append` is *not* specified.
http://reviews.llvm.org/D10868
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the lldb-commits
mailing list