[Lldb-commits] [PATCH] Fix TestCreateAfterAttach on Windows

[Adrian McCarthy]

Hi chaoren,

Ported pthreads-based inferior to std::thread.

Adjusted TestCreateAfterAttach accordingly.  The thread numbers with std::thread are not deterministic, so instead we check which functions the stopped threads are in.

This uncovered that stepping over a breakpoint was broken on Windows because it was expecting the thread resume state rather than the temporary resume states to change.  This was fixed.  (This seemed to work in the past, until my change from a couple weeks ago which stopped TargetWindowsThread::WillResume from stomping the thread resume state.)

Removed slightly misleading Windows-only logging message.

TestCreateAfterAttach now works on Windows except for some lingering POSIXisms in lldbtest.py.  I'll address those in a later patch.

http://reviews.llvm.org/D10850

Files:
  source/Plugins/Process/Windows/TargetThreadWindows.cpp
  test/functionalities/thread/create_after_attach/Makefile
  test/functionalities/thread/create_after_attach/TestCreateAfterAttach.py
  test/functionalities/thread/create_after_attach/main.c
  test/functionalities/thread/create_after_attach/main.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10850.28817.patch
Type: text/x-patch
Size: 10074 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150630/7f3cc138/attachment.bin>