[Lldb-commits] [lldb] r240606 - Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin types in clang trunk

[Enrico Granata]

> On Jun 29, 2015, at 8:17 AM, Ed Maste <emaste at freebsd.org> wrote:
> 
> On 24 June 2015 at 19:13, Enrico Granata <egranata at apple.com> wrote:
>> Author: enrico
>> Date: Wed Jun 24 18:13:23 2015
>> New Revision: 240606
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=240606&view=rev
>> Log:
>> Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin types in clang trunk
> 
> This introduces a warning now that all enum values are covered in the switch.
> 
> ../tools/lldb/source/Symbol/ClangASTType.cpp:2215:13: warning: default
> label in switch which covers all enumeration values
> [-Wcovered-switch-default]
>            default: assert(0 && "Unknown builtin type!");
> 
> Shall I just remove the default?


Are you trying to build with -Werror?
We are not here, so warnings don’t cause our builds to fail - and in this case, I slightly prefer the default to stay

With that said, if you’re going for warning-free builds, then yes, let’s think of a way forward - the fact that we were not handling all cases was not intentional, just a by-product of clang adding new kinds that we didn’t run into/need to handle

Thanks,
- Enrico
📩 egranata@.com ☎️ 27683

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150629/0372e12b/attachment.html>