[Lldb-commits] [PATCH] Fix [vdso] handling on Android (x86 and aarch64)

[Pavel Labath]

In http://reviews.llvm.org/D10800#196359, @tberghammer wrote:

> In http://reviews.llvm.org/D10800#196243, @labath wrote:
>
> > Would it be possible to add a test for this somehow? Check the output of `image list`? Look up a symbol in the vdso? Try to hit a breakpoint inside it?
>
>
> It is quite complicated to test anything inside the [vdso] because as far as I know there is no specification about the list of functions what should be present in it. Checking the output of "image list" is possible but it won't give us too much coverage because it will be displayed there in several cases when it isn't loaded correctly.


Yes, I suspect the contents of the vdso is highly platform-dependent. However, it (vdso) has to remain backward compatible with old binaries (and old versions of libc), therefore I think it's unlikely that a symbol will disappear from there overnight. I think the vdso support is very prone to accidental breakage at this point, so it would be good to get *any* coverage - it does not have to be exhaustive, but picking a symbol on one-or-two platforms and checking that should be possible.


http://reviews.llvm.org/D10800

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/