[Lldb-commits] [PATCH] [linux] Use cmake to detect support process_vm_readv (bug #23918)

[Pavel Labath]

> source/Host/linux/LibcGlue.cpp also need to include #include <unistd.h> (for syscall() prototype). Sorry, I didn't catch it yesterday because I incorrectly applied ifndef.


I've added unistd.h and committed. Let me know if you see any problems.

> Man page tells to define #define _GNU_SOURCE before #include <unistd.h>.


This macro is defined (for me at least) on the compiler command line. If this is not the case for you, then we can work it out separately.

> I'm not sure, but probably macro should start from HAS, not HAVE, since they are about operation system.


I am testing a feature of the c library (the support in the actual running kernel will be tested at runtime - we need this that way), which seems consistent with all the other HAVE_ macros i've seen.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D10727

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/