[Lldb-commits] [lldb] r240737 - Re-enable 'process save-core' for arm64 targets.

Jason Molenda jmolenda at apple.com
Thu Jun 25 16:58:25 PDT 2015


Author: jmolenda
Date: Thu Jun 25 18:58:25 2015
New Revision: 240737

URL: http://llvm.org/viewvc/llvm-project?rev=240737&view=rev
Log:
Re-enable 'process save-core' for arm64 targets.
Whatever problem I saw that caused me to disable this
initially is not a problem today.
<rdar://problem/21173317>
<rdar://problem/20266253> 

Modified:
    lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp?rev=240737&r1=240736&r2=240737&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Thu Jun 25 18:58:25 2015
@@ -5675,11 +5675,7 @@ ObjectFileMachO::SaveCore (const lldb::P
             bool make_core = false;
             switch (target_arch.GetMachine())
             {
-                  // arm64 core file writing is having some problem with writing  down the 
-                  // dyld shared images info struct and/or the main executable binary. May
-                  // turn out to be a debugserver problem, not sure yet.
-//                case llvm::Triple::aarch64:
-
+                case llvm::Triple::aarch64:
                 case llvm::Triple::arm:
                 case llvm::Triple::x86:
                 case llvm::Triple::x86_64:





More information about the lldb-commits mailing list