[Lldb-commits] [PATCH] [linux] Use cmake to detect support process_vm_readv (bug #23918)

[Oleksiy Vyalov]

================
Comment at: cmake/modules/LLDBConfig.cmake:258
@@ +257,3 @@
+
+int main() { return process_vm_readv(0, 0, 0, 0, 0, 0); }
+"
----------------
Do we need to cast from ssize_t to int?

================
Comment at: cmake/modules/LLDBConfig.cmake:258
@@ +257,3 @@
+
+int main() { return process_vm_readv(0, 0, 0, 0, 0, 0); }
+"
----------------
ovyalov wrote:
> Do we need to cast from ssize_t to int?
Could you pass nullptr for const struct iovec *?

================
Comment at: source/Host/linux/LibcGlue.cpp:10
@@ -9,5 +9,3 @@
 
-// This files adds functions missing from libc on earlier versions of Android
-
-#include <android/api-level.h>
+// This files adds functions missing from libc on older versions of linux
 
----------------
s/files/file

http://reviews.llvm.org/D10727

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/