[Lldb-commits] [lldb] r240549 - Remove empty ProcessPOSIX::StopAllThreads

[Ed Maste]

Author: emaste
Date: Wed Jun 24 11:24:56 2015
New Revision: 240549

URL: http://llvm.org/viewvc/llvm-project?rev=240549&view=rev
Log:
Remove empty ProcessPOSIX::StopAllThreads

The removal of ProcessLinux in r240543 left only an empty
StopAllThreads (it's not needed on FreeBSD), so just remove it too.

Modified:
    lldb/trunk/source/Plugins/Process/FreeBSD/ProcessPOSIX.cpp
    lldb/trunk/source/Plugins/Process/FreeBSD/ProcessPOSIX.h

Modified: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessPOSIX.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/FreeBSD/ProcessPOSIX.cpp?rev=240549&r1=240548&r2=240549&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/FreeBSD/ProcessPOSIX.cpp (original)
+++ lldb/trunk/source/Plugins/Process/FreeBSD/ProcessPOSIX.cpp Wed Jun 24 11:24:56 2015
@@ -385,13 +385,11 @@ ProcessPOSIX::SendMessage(const ProcessM
             }
             else
             {
-                StopAllThreads(message.GetTID());
                 SetPrivateState(eStateStopped);
             }
         }
         else
         {
-            StopAllThreads(message.GetTID());
             SetPrivateState(eStateStopped);
         }
         break;
@@ -427,7 +425,6 @@ ProcessPOSIX::SendMessage(const ProcessM
     case ProcessMessage::eCrashMessage:
         assert(thread);
         thread->SetState(eStateStopped);
-        StopAllThreads(message.GetTID());
         SetPrivateState(eStateStopped);
         break;
 
@@ -440,7 +437,6 @@ ProcessPOSIX::SendMessage(const ProcessM
         }
         assert(thread);
         thread->SetState(eStateStopped);
-        StopAllThreads(message.GetTID());
         SetPrivateState(eStateStopped);
         break;
     }
@@ -449,7 +445,6 @@ ProcessPOSIX::SendMessage(const ProcessM
     {
         assert(thread);
         thread->SetState(eStateStopped);
-        StopAllThreads(message.GetTID());
         SetPrivateState(eStateStopped);
         break;
     }
@@ -459,12 +454,6 @@ ProcessPOSIX::SendMessage(const ProcessM
     m_message_queue.push(message);
 }
 
-void 
-ProcessPOSIX::StopAllThreads(lldb::tid_t stop_tid)
-{
-    // FIXME: Will this work the same way on FreeBSD and Linux?
-}
-
 bool
 ProcessPOSIX::AddThreadForInitialStopIfNeeded(lldb::tid_t stop_tid)
 {

Modified: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessPOSIX.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/FreeBSD/ProcessPOSIX.h?rev=240549&r1=240548&r2=240549&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/FreeBSD/ProcessPOSIX.h (original)
+++ lldb/trunk/source/Plugins/Process/FreeBSD/ProcessPOSIX.h Wed Jun 24 11:24:56 2015
@@ -156,11 +156,6 @@ public:
                 const lldb_private::FileSpec &default_file_spec,
                 const lldb_private::FileSpec &dbg_pts_file_spec);
 
-    /// Stops all threads in the process.
-    /// The \p stop_tid parameter indicates the thread which initiated the stop.
-    virtual void
-    StopAllThreads(lldb::tid_t stop_tid);
-
     /// Adds the thread to the list of threads for which we have received the initial stopping signal.
     /// The \p stop_tid parameter indicates the thread which the stop happened for.
     bool