[Lldb-commits] [lldb] r240546 - Proper handling of QNonStop packet response.

[Ewan Crawford]

Author: ewancrawford
Date: Wed Jun 24 10:14:26 2015
New Revision: 240546

URL: http://llvm.org/viewvc/llvm-project?rev=240546&view=rev
Log:
Proper handling of QNonStop packet response.

Turn non-stop mode off if reply to QNonStop packet isn't an OK.

Modified:
    lldb/trunk/include/lldb/Target/Target.h
    lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    lldb/trunk/source/Target/Target.cpp

Modified: lldb/trunk/include/lldb/Target/Target.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/Target.h?rev=240546&r1=240545&r2=240546&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Target/Target.h (original)
+++ lldb/trunk/include/lldb/Target/Target.h Wed Jun 24 10:14:26 2015
@@ -198,7 +198,10 @@ public:
 
     bool
     GetNonStopModeEnabled () const;
-    
+
+    void
+    SetNonStopModeEnabled (bool b);
+
     bool
     GetDisplayRuntimeSupportValues () const;
     

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp?rev=240546&r1=240545&r2=240546&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Wed Jun 24 10:14:26 2015
@@ -1172,7 +1172,7 @@ ProcessGDBRemote::ConnectToDebugserver (
 
     // Send $QNonStop:1 packet on startup if required
     if (GetTarget().GetNonStopModeEnabled())
-        m_gdb_comm.SetNonStopMode(true);
+        GetTarget().SetNonStopModeEnabled (m_gdb_comm.SetNonStopMode(true));
 
     m_gdb_comm.GetEchoSupported ();
     m_gdb_comm.GetThreadSuffixSupported ();

Modified: lldb/trunk/source/Target/Target.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Target.cpp?rev=240546&r1=240545&r2=240546&view=diff
==============================================================================
--- lldb/trunk/source/Target/Target.cpp (original)
+++ lldb/trunk/source/Target/Target.cpp Wed Jun 24 10:14:26 2015
@@ -3550,6 +3550,13 @@ TargetProperties::GetNonStopModeEnabled
     return m_collection_sp->GetPropertyAtIndexAsBoolean (NULL, idx, false);
 }
 
+void
+TargetProperties::SetNonStopModeEnabled (bool b)
+{
+    const uint32_t idx = ePropertyNonStopModeEnabled;
+    m_collection_sp->SetPropertyAtIndexAsBoolean (NULL, idx, b);
+}
+
 const ProcessLaunchInfo &
 TargetProperties::GetProcessLaunchInfo ()
 {