[Lldb-commits] [PATCH] Add -lpthread to LLDB shared lib link line unconditionally

[Pavel Labath]

I'm just trying to understand what are the implications of this.

Right now, using LLDB_DISABLE_PYTHON will prevent lldb from linking
against python. Is that correct?

With your patch the flag will also prevent the generation of the
python SBAPI? Or what exactly?


On 18 June 2015 at 17:21, Keno Fischer <kfischer at college.harvard.edu> wrote:
> REPOSITORY
>   rL LLVM
>
> ================
> Comment at: scripts/CMakeLists.txt:1
> @@ -1,1 +1,2 @@
> -set(LLVM_NO_RTTI 1)
> +if (NOT LLDB_DISABLE_PYTHON)
> +       set(LLVM_NO_RTTI 1)
> ----------------
> labath wrote:
>> What was the exact reason you needed to add this?
> We disable threads and LLDB_DISABLE_PYTHON and all of this disables python stuff that isn't needed (and errors if you don't use python/don't have it installed). Originally I only had the Makefile change, but I was asked to check if cmake worked in this configuration, and this was the one thing I had to change to make it work. I'll happily make this a separate commit, it was just here for convenience.
>
> http://reviews.llvm.org/D5431
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>