[Lldb-commits] [PATCH] Avoid querying thread stop info if the thread hasn't been running

Pavel Labath labath at google.com
Thu Jun 18 16:53:29 PDT 2015


In http://reviews.llvm.org/D10550#190560, @jingham wrote:

> I thought about this for much the same reason just a little while ago.  Turns out OS X, it is possible for us to stop a process, and fetch all the exceptions, but have some thread exception that wasn't quite ready to be delivered to that thread.  The next time you let the task run, that exception will get delivered to the thread even though it is suspended.  So it isn't safe to assume that just because WE suspended a thread, it won't have an interesting stop reason, and we had to think of another way to get around this.


That is interesting. As far as I know such a thing cannot happen on linux, but I was wondering if the same is true for other platforms. I will abandon this change then.

> Our alternate was to add a "get all thread stop reasons" packet to our extended remote protocol so once you get the stop reply packet you can turn around and get all the remaining stop reasons in one blow.


That was our line of reasoning as well. Thanks for the heads up. I will wait for the change to land.

cheers,
pl


http://reviews.llvm.org/D10550

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list