[Lldb-commits] [PATCH] Fix process attach and detach for Windows

Pavel Labath labath at google.com
Thu Jun 18 16:42:54 PDT 2015

Looks better, but I have one more hypothetical question.

Comment at: source/Plugins/Process/Windows/DebuggerThread.cpp:229
@@ -231,1 +228,3 @@
+        // Force a fresh break so that the detach can happen from the debugger thread.
+        if (!::DebugBreakProcess(GetProcess().GetNativeProcess().GetSystemHandle()))
If I understand correctly, you have let the process run freely a couple of lines back.(?)
What will happen if the process stops again (another breakpoint, watchpoint, access violation, ..) before you get a chance to stop it here? Can such a thing happen?

Comment at: source/Plugins/Process/Windows/ProcessWindows.cpp:1013
@@ -913,1 +1012,2 @@
This looks unnecessary.



More information about the lldb-commits mailing list