[Lldb-commits] [PATCH] Add handling of async notify packets.

Greg Clayton clayborg at gmail.com
Thu Jun 18 10:41:03 PDT 2015


Please remove the whitespace only changes and this will be good to go.


REPOSITORY
  rL LLVM

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3339
@@ -3299,3 +3338,3 @@
+                                        // using the process->SetLastStopPacket()...
                                         process->ClearThreadIDList();
                                         
----------------
remove whitespace only changes

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3346-3347
@@ +3345,4 @@
+                                            case eStateSuspended:
+                                                process->SetLastStopPacket(response);
+                                                process->SetPrivateState(stop_state);
+                                                break;
----------------
remove whitespace only changes

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3352
@@ -3310,2 +3351,3 @@
                                             {
-                                                if (desc_token == "description")
+                                                process->SetLastStopPacket(response);
+                                                process->ClearThreadIDList();
----------------
remove whitespace only changes

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3363
@@ +3362,3 @@
+                                                    std::string desc_token;
+                                                    while (response.GetNameColonValue(desc_token, desc_string))
+                                                    {
----------------
remove whitespace only changes

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3369
@@ +3368,3 @@
+                                                            extractor.SetFilePos(0);
+                                                            extractor.GetHexByteString(desc_string);
+                                                            desc_cstr = desc_string.c_str();
----------------
remove whitespace only changes

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3383
@@ +3382,3 @@
+                                            default:
+                                                process->SetPrivateState(stop_state);
+                                                break;
----------------
remove whitespace only changes

http://reviews.llvm.org/D10544

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list