[Lldb-commits] [lldb] r239996 - [LLDB][MIPS] Emulation of MIPS64 floating-point branch instructions

[Ed Maste]

On 18 June 2015 at 02:03, Mohit K. Bhakkad <mohit.bhakkad at gmail.com> wrote:
> Author: mohit.bhakkad
> Date: Thu Jun 18 01:03:27 2015
> New Revision: 239996
>
> URL: http://llvm.org/viewvc/llvm-project?rev=239996&view=rev
> Log:
> [LLDB][MIPS] Emulation of MIPS64 floating-point branch instructions
> Patch by Jaydeep Patil
...
>          std::string thumb_triple(thumb_arch.GetTriple().getTriple());
> -        m_alternate_disasm_ap.reset(new LLVMCDisassembler(thumb_triple.c_str(), flavor, *this));
> +        m_alternate_disasm_ap.reset(new LLVMCDisassembler(thumb_triple.c_str(), nullptr, flavor, *this));
>          if (!m_alternate_disasm_ap->IsValid())

This introduces an assertion failure when I run the test suite. This
is on FreeBSD, but I don't see why it should be any different on other
platforms. Did it pass for you?

Assertion failed: (Str && "StringRef cannot be built from a NULL
argument"), function StringRef, file ../include/llvm/ADT/StringRef.h,
line 71.

(lldb) bt
* thread #1: tid = 0, 0x0000000801842ffa libc.so.7`__sys_thr_kill + 10
at thr_kill.S:3, name = 'python2.7', stop reason = signal SIGABRT
  * frame #0: 0x0000000801842ffa libc.so.7`__sys_thr_kill + 10 at thr_kill.S:3
    frame #1: 0x0000000801842f66 libc.so.7`__raise(s=<unavailable>) +
38 at raise.c:51
    frame #2: 0x0000000801841759 libc.so.7`abort + 73 at abort.c:65
    frame #3: 0x00000008018235f1
libc.so.7`__assert(func=<unavailable>, file=<unavailable>,
line=<unavailable>, failedexpr=<unavailable>) + 81 at assert.c:54
    frame #4: 0x000000080691b071
_lldb.so`StringRef(this=0x00007fffffff5e30, Str=0x0000000000000000) +
81 at StringRef.h:71
    frame #5: 0x00000008088c6a35
_lldb.so`LLVMCDisassembler(this=0x00000008044d2340,
triple=0x00007fffffff6a71, cpu=0x0000000000000000, flavor=4294967295,
owner=0x000000080201aa40) + 2277 at DisassemblerLLVMC.cpp:434
    frame #6: 0x00000008088c9e80
_lldb.so`DisassemblerLLVMC(this=0x000000080201aa40,
arch=0x000000080203f7b8, flavor_string=0x0000000000000000) + 3888 at
DisassemblerLLVMC.cpp:690
    frame #7: 0x00000008088c8cc2
_lldb.so`DisassemblerLLVMC::CreateInstance(arch=0x000000080203f7b8,
flavor=0x0000000000000000) + 162 at DisassemblerLLVMC.cpp:572
...