[Lldb-commits] [lldb] r240016 - [LLDB][MIPS] Addressing some errors and warnings due to rL239991

[Mohit K. Bhakkad]

Author: mohit.bhakkad
Date: Thu Jun 18 08:35:29 2015
New Revision: 240016

URL: http://llvm.org/viewvc/llvm-project?rev=240016&view=rev
Log:
[LLDB][MIPS] Addressing some errors and warnings due to rL239991

Modified:
    lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
    lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.h

Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp?rev=240016&r1=240015&r2=240016&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp (original)
+++ lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp Thu Jun 18 08:35:29 2015
@@ -330,8 +330,8 @@ namespace
 
     //------------------------------------------------------------------------------
     /// @class ReadWatchPointRegOperation
-    /// @brief Implements NativeProcessLinux::ReadWatchPointRegisterValue.
-    class ReadWatchPointRegOperation : public Operation
+    /// @brief Implements NativeRegisterContextLinux_mips64::ReadWatchPointRegisterValue.
+    class ReadWatchPointRegOperation : public NativeProcessLinux::Operation
     {
     public:
         ReadWatchPointRegOperation (
@@ -351,8 +351,8 @@ namespace
 
     //------------------------------------------------------------------------------
     /// @class SetWatchPointRegOperation
-    /// @brief Implements NativeProcessLinux::SetWatchPointRegisterValue.
-    class SetWatchPointRegOperation : public Operation
+    /// @brief Implements NativeRegisterContextLinux_mips64::SetWatchPointRegisterValue.
+    class SetWatchPointRegOperation : public NativeProcessLinux::Operation
     {
     public:
         SetWatchPointRegOperation (
@@ -769,6 +769,7 @@ GetWatchHi (struct pt_watch_regs *regs,
         return regs->mips64.watchhi[index];
     else
         log->Printf("Invalid watch register style");
+    return 0;
 }
 
 static void
@@ -781,6 +782,7 @@ SetWatchHi (struct pt_watch_regs *regs,
         regs->mips64.watchhi[index] = value;
     else
         log->Printf("Invalid watch register style");
+    return;
 }
 
 static lldb::addr_t
@@ -793,6 +795,7 @@ GetWatchLo (struct pt_watch_regs *regs,
         return regs->mips64.watchlo[index];
     else
         log->Printf("Invalid watch register style");
+    return LLDB_INVALID_ADDRESS;
 }
 
 static void
@@ -805,6 +808,7 @@ SetWatchLo (struct pt_watch_regs *regs,
         regs->mips64.watchlo[index] = value;
     else
         log->Printf("Invalid watch register style");
+    return;
 }
 
 static uint32_t
@@ -817,6 +821,7 @@ GetIRWMask (struct pt_watch_regs *regs,
         return regs->mips64.watch_masks[index] & IRW;
     else
         log->Printf("Invalid watch register style");
+    return 0;
 }
 
 static uint32_t
@@ -829,6 +834,7 @@ GetRegMask (struct pt_watch_regs *regs,
         return regs->mips64.watch_masks[index] & ~IRW;
     else
         log->Printf("Invalid watch register style");
+    return 0;
 }
 
 static lldb::addr_t
@@ -1117,15 +1123,15 @@ NativeRegisterContextLinux_mips64::GetWr
 }
 
 NativeProcessLinux::OperationUP
-NativeRegisterContextLinux_mips64::GetReadWatchPointRegisterValue(lldb::tid_t tid, void* watch_readback)
+NativeRegisterContextLinux_mips64::GetReadWatchPointRegisterValueOperation(lldb::tid_t tid, void* watch_readback)
 {
     return NativeProcessLinux::OperationUP(new ReadWatchPointRegOperation(m_thread.GetID(), watch_readback));
 }
 
 NativeProcessLinux::OperationUP
-NativeRegisterContextLinux_mips64::GetWriteWatchPointRegisterValue(lldb::tid_t tid, void* watch_reg_value)
+NativeRegisterContextLinux_mips64::GetWriteWatchPointRegisterValueOperation(lldb::tid_t tid, void* watch_reg_value)
 {
-    return NativeProcessLinux::OperationUP(new SetWatchPointRegOperation(m_thread.GetID(), watch_readback));
+    return NativeProcessLinux::OperationUP(new SetWatchPointRegOperation(m_thread.GetID(), watch_reg_value));
 }
 
 #endif // defined (__mips__)

Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.h?rev=240016&r1=240015&r2=240016&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.h (original)
+++ lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.h Thu Jun 18 08:35:29 2015
@@ -96,12 +96,12 @@ namespace process_linux {
                                        const RegisterValue &value) override;
 
         NativeProcessLinux::OperationUP
-        GetReadWatchPointRegisterValue(lldb::tid_t tid,
-                                       void* watch_readback);
+        GetReadWatchPointRegisterValueOperation(lldb::tid_t tid,
+                                                void* watch_readback);
 
         NativeProcessLinux::OperationUP
-        GetWriteWatchPointRegisterValue(lldb::tid_t tid,
-                                       void* watch_readback);
+        GetWriteWatchPointRegisterValueOperation(lldb::tid_t tid,
+                                                 void* watch_readback);
 
         bool
         IsFR0();