[Lldb-commits] [PATCH] Fetch object file load address if it isn't specified by the linker

[Oleksiy Vyalov]

================
Comment at: include/lldb/Host/common/NativeProcessProtocol.h:297
@@ -295,1 +296,3 @@
 
+        virtual Error
+        GetFileLoadAddress(const llvm::StringRef& file_name, lldb::addr_t& load_addr)
----------------
Nit - I think it's ok to make method pure virtual in order to follow existing style in NativeProcessProtocol

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4121
@@ +4120,3 @@
+{
+    load_addr = LLDB_INVALID_ADDRESS;
+
----------------
Please set is_loaded = false.

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4132
@@ +4131,3 @@
+    StringExtractorGDBRemote response;
+    m_gdb_comm.SendPacketAndWaitForResponse(packet.GetString().c_str(), response, false);
+    if (response.IsErrorResponse())
----------------
Could you check for return value of SendPacketAndWaitForResponse?

http://reviews.llvm.org/D10490

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/