[Lldb-commits] [PATCH] Add a test for expression evaluation while inferior is blocked in a syscall

[Pavel Labath]

================
Comment at: test/expression_command/expr-in-syscall/TestExpressionInSyscall.py:53
@@ +52,3 @@
+
+        # give the child enough time to reach the syscall
+        # clearing out all the pending events
----------------
tberghammer wrote:
> What gives time to the inferior to reach the syscall?
> Should we add a sleep(1) here?
The last WaitForEvent call will time out after 2 seconds, when there are no more pending events.

================
Comment at: test/expression_command/expr-in-syscall/TestExpressionInSyscall.py:56
@@ +55,3 @@
+        while listener.WaitForEvent(2, event):
+            True
+
----------------
tberghammer wrote:
> (nit): The "idiomatic" way for this is to use the "pass" keyword
Ah, that's good to know.

http://reviews.llvm.org/D10519

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/