[Lldb-commits] [PATCH] Add negative test for target.move-to-nearest-code=off using source location
Hafiz Abid Qadeer
abidh.haq at gmail.com
Wed Jun 17 02:12:11 PDT 2015
Apart from one comment, looks good.
REPOSITORY
rL LLVM
================
Comment at: test/tools/lldb-mi/breakpoint/TestMiBreak.py:189
@@ -184,2 +188,3 @@
self.expect("\^done")
+ # FIXME BP was increased by 1 after setting non-pending BP on unknown location (number should be 2)
self.runCmd("-break-insert main.cpp:%d" % line)
----------------
I am not sure if this needs fixing. There can be argument either way. So it will be best to just mention it in the comment once and remove all the other FIXME lines.
http://reviews.llvm.org/D10486
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the lldb-commits
mailing list