[Lldb-commits] [PATCH] Fetch object file load address if it isn't specified by the linker

Pavel Labath labath at google.com
Tue Jun 16 19:28:17 PDT 2015

looks mostly good. I would just like to clarify a few things in the protocol...

Comment at: docs/lldb-gdb-remote.txt:999
@@ +998,3 @@
+//  <unsinged-hex64>: The load address of the file
+//  "FFFFFFFFFFFFFFFF": ((uint64_t)(-1)) The requested file isn't loaded
What is going to be the endianness of this value? I propose big endian, as that is what most packets seem to be using.

Comment at: docs/lldb-gdb-remote.txt:1001
@@ +1000,3 @@
+//  "FFFFFFFFFFFFFFFF": ((uint64_t)(-1)) The requested file isn't loaded
+//  "EXX" - for any errors
I know F..F is not likely to be a valid load address, but what do you think about using one of the error codes to signify this condition? If it is not too much of a trouble to implement it, it sounds like a more reasonable solution.

Comment at: include/lldb/Target/Process.h:3049
@@ +3048,3 @@
+    ///     The load address of the file if it is loaded into the
+    ///     processes address space. LLDB_INAVLID_ADDRESS if the file
+    ///     isn't loaded.



More information about the lldb-commits mailing list