[Lldb-commits] [PATCH] [TestLoadUnload] Enable for Android while skipping it for other remotes.

[Tamas Berghammer]

Why do you enable these tests only on remote Android? I think they should work on any remote target with your fix (where the test makes sense)


================
Comment at: test/functionalities/load_unload/TestLoadUnload.py:59
@@ +58,3 @@
+                err = lldb.remote_platform.Run(
+                    lldb.SBPlatformShellCommand("mkdir %s" % hidden_dir))
+                if err.Fail():
----------------
I think this will fail in case of Windows -> Android (wrong path separator). You can use SBPlatform::MakeDirectory what should work in all cases

================
Comment at: test/functionalities/load_unload/TestLoadUnload.py:177
@@ +176,3 @@
+            err = lldb.remote_platform.Run(
+                lldb.SBPlatformShellCommand("rm %s" % old_dylib))
+            if err.Fail():
----------------
Same here

http://reviews.llvm.org/D10469

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/