[Lldb-commits] [PATCH] Fetch object file load address if it isn't specified by the linker

[Pavel Labath]

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2607
@@ +2606,3 @@
+    // Fail if we don't have a current process.
+    if (!m_debugged_process_sp ||
+            m_debugged_process_sp->GetID () == LLDB_INVALID_PROCESS_ID)
----------------
I am wondering whether we shouldn't thread the implementation of this down to NativeProcessLinux. Parsing of files in the proc filesystem is unlikely to be fruitful on non-linux systems...

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2627
@@ +2626,3 @@
+ 
+            if (maps_columns.size() >= 6)
+            {
----------------
Nit: LLVM style guide recommends early exits to simplify things:
```
if (size() < 6)
  return true;
if (column[5] != file_name)
  return true;
...
```

http://reviews.llvm.org/D10490

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/