[Lldb-commits] [PATCH] Skip TestInferiorChanged if host platform is windows.

[Zachary Turner]

On Fri, Jun 5, 2015 at 8:31 PM Chaoren Lin <chaorenl at google.com> wrote:

> Hi ovyalov, zturner, clayborg,
>
> Opened files on Windows cannot be modified, so this test doesn't make
> sense.
>
> http://reviews.llvm.org/D10295
>
> Files:
>   test/functionalities/inferior-changed/TestInferiorChanged.py
>   test/lldbtest.py
>
> Index: test/functionalities/inferior-changed/TestInferiorChanged.py
> ===================================================================
> --- test/functionalities/inferior-changed/TestInferiorChanged.py
> +++ test/functionalities/inferior-changed/TestInferiorChanged.py
> @@ -21,6 +21,7 @@
>          self.setTearDownCleanup(dictionary=d)
>          self.inferior_not_crashing()
>
> +    @skipIfHostWindows
>      def test_inferior_crashing_dwarf(self):
>          """Test lldb reloads the inferior after it was changed during the
> session."""
>          self.buildDwarf()
> Index: test/lldbtest.py
> ===================================================================
> --- test/lldbtest.py
> +++ test/lldbtest.py
> @@ -778,6 +778,10 @@
>      """Decorate the item to skip tests that should be skipped on
> Windows."""
>      return skipIfPlatform(["windows"])(func)
>
> +def skipIfHostWindows(func):
> +    """Decorate the item to skip tests that should be skipped on
> Windows."""
> +    return skipIfHostPlatform(["windows"])(func)
> +
>
How is this different than @skipIfWindows, which we already have?  Seems
like we should use one or the other.



>  def skipUnlessDarwin(func):
>      """Decorate the item to skip tests that should be skipped on any non
> Darwin platform."""
>      return skipUnlessPlatform(getDarwinOSTriples())(func)
> @@ -827,6 +831,16 @@
>              func(*args, **kwargs)
>      return wrapper
>
> +def skipIfHostPlatform(oslist):
> +    """Decorate the item to skip tests if running on one of the listed
> host platforms."""
> +    return unittest2.skipIf(getHostPlatform() in oslist,
> +                            "skip on %s" % (", ".join(oslist)))
> +
> +def skipUnlessHostPlatform(oslist):
> +    """Decorate the item to skip tests unless running on one of the
> listed host platforms."""
> +    return unittest2.skipUnless(getHostPlatform() in oslist,
> +                                "requires on of %s" % (", ".join(oslist)))
> +
>  def skipIfPlatform(oslist):
>      """Decorate the item to skip tests if running on one of the listed
> platforms."""
>      return unittest2.skipIf(getPlatform() in oslist,
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150606/74719eaa/attachment.html>