[Lldb-commits] [PATCH] Introduced SysV ABI support for i386 Architecture

[Ed Maste]

On 5 June 2015 at 07:35, <abhishek.a.aggarwal at intel.com> wrote:
>
> From: Abhishek Aggarwal <abhishek.a.aggarwal at intel.com>
>
>  - Executables compiled for i386 architecture can now be
>    debugged both locally and remotely
>
>  - Additional effort is required to complete the implementation
>    e.g. SetReturnValueObject is yet to be implemented

You might like to put this in Phabricator for review as well - that
better fits the workflow of some reviewers.

> --- a/source/Plugins/ABI/CMakeLists.txt
> +++ b/source/Plugins/ABI/CMakeLists.txt
> @@ -3,6 +3,7 @@ add_subdirectory(SysV-arm64)
>  add_subdirectory(SysV-hexagon)
>  add_subdirectory(SysV-ppc)
>  add_subdirectory(SysV-ppc64)
> +add_subdirectory(SysV-i386)

Ought to be in alpha order.

> +    { "eax",    NULL,    4,  0, eEncodingUint  , eFormatHex          , { gcc_dwarf_eax       , gcc_dwarf_eax           , LLDB_INVALID_REGNUM       , gdb_eax            , LLDB_INVALID_REGNUM },      NULL,        NULL},

Minor nitpicky comment, you may want to use nullptr in new files
rather than NULL. We've had some attempts in the past to switch over
that haven't been committed, but for brand-new files we might as well
start off with it.