[Lldb-commits] [lldb] r239104 - [TestGdbRemoteRegisterState] Do not flip ARM *psr register in the test

Siva Chandra sivachandra at google.com
Thu Jun 4 15:04:04 PDT 2015


Author: sivachandra
Date: Thu Jun  4 17:04:04 2015
New Revision: 239104

URL: http://llvm.org/viewvc/llvm-project?rev=239104&view=rev
Log:
[TestGdbRemoteRegisterState] Do not flip ARM *psr register in the test

Summary:
Not all of that register is readable/writable in user mode. This means
that even if the inferior is stopped, parts of the register could be
changing. So, do not flip this register to check if its value can be
restored.

Reviewers: tberghammer, chaoren

Reviewed By: tberghammer

Subscribers: rengolin, aemerson, lldb-commits

Differential Revision: http://reviews.llvm.org/D10204

Modified:
    lldb/trunk/test/tools/lldb-server/gdbremote_testcase.py

Modified: lldb/trunk/test/tools/lldb-server/gdbremote_testcase.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/tools/lldb-server/gdbremote_testcase.py?rev=239104&r1=239103&r2=239104&view=diff
==============================================================================
--- lldb/trunk/test/tools/lldb-server/gdbremote_testcase.py (original)
+++ lldb/trunk/test/tools/lldb-server/gdbremote_testcase.py Thu Jun  4 17:04:04 2015
@@ -1065,6 +1065,9 @@ class GdbRemoteTestCaseBase(TestBase):
             # This is a 2-letter register name that ends in "s", like a segment register.
             # Don't try to bit flip these.
             return False
+        if re.match("^(c|)psr$", reg_info["name"]):
+            # This is an ARM program status register; don't flip it.
+            return False
         # Okay, this looks fine-enough.
         return True
 





More information about the lldb-commits mailing list