[Lldb-commits] [lldb] r238752 - Refactor many file functions to use FileSpec over strings.

[Ed Maste]

On 1 June 2015 at 11:24, Ed Maste <emaste at freebsd.org> wrote:
>
> Author: emaste
> Date: Mon Jun  1 10:24:37 2015
> New Revision: 238752
>
> URL: http://llvm.org/viewvc/llvm-project?rev=238752&view=rev
> Log:
> Refactor many file functions to use FileSpec over strings.
>
> This is the FreeBSD change for r238604.

For better or worse FreeBSD/ProcessMonitor.cpp and
Linux/ProcessMonitor.cpp have a large amount of identical code, and
many changes to one apply directly to the other -- as is the case
here.

Longer term this will become less of an issue, as (a)
Linux/ProcessMonitor.cpp will be deprecated and (b) FreeBSD will
migrate to a Native{Process,Thread}FreeBSD implementation similar to
Native{Process,Thread}Linux. In the interim I'd appreciate it if
straightforward changes to Linux/ProcessMonitor.cpp can be applied to
FreeBSD/ProcessMonitor.cpp as well though. I'd rather have an untested
change committed to the FreeBSD ProcessMonitor implementation than to
have the build left broken until I'm able to look at it.