[Lldb-commits] [PATCH] Remove "%zu" format specifier for MSVC.

Zachary Turner zturner at google.com
Sun May 31 21:16:59 PDT 2015


Lgtm. Just as an fyi, 2015 supports %z, so once we raise the minimum
requirement we won't have this problem anymore
On Sun, May 31, 2015 at 8:24 PM Chaoren Lin <chaorenl at google.com> wrote:

> Hi zturner,
>
> http://reviews.llvm.org/D10153
>
> Files:
>   source/Symbol/ClangASTType.cpp
>
> Index: source/Symbol/ClangASTType.cpp
> ===================================================================
> --- source/Symbol/ClangASTType.cpp
> +++ source/Symbol/ClangASTType.cpp
> @@ -3712,7 +3712,7 @@
>                      if (element_type.GetCompleteType())
>                      {
>                          char element_name[64];
> -                        ::snprintf (element_name, sizeof (element_name),
> "[%zu]", idx);
> +                        ::snprintf(element_name, sizeof(element_name),
> "[%" PRIu64 "]", static_cast<uint64_t>(idx));
>                          child_name.assign(element_name);
>                          child_byte_size =
> element_type.GetByteSize(exe_ctx ? exe_ctx->GetBestExecutionContextScope()
> : NULL);
>                          child_byte_offset = (int32_t)idx *
> (int32_t)child_byte_size;
> @@ -3733,7 +3733,7 @@
>                      if (element_type.GetCompleteType())
>                      {
>                          char element_name[64];
> -                        ::snprintf (element_name, sizeof (element_name),
> "[%zu]", idx);
> +                        ::snprintf(element_name, sizeof(element_name),
> "[%" PRIu64 "]", static_cast<uint64_t>(idx));
>                          child_name.assign(element_name);
>                          child_byte_size =
> element_type.GetByteSize(exe_ctx ? exe_ctx->GetBestExecutionContextScope()
> : NULL);
>                          child_byte_offset = (int32_t)idx *
> (int32_t)child_byte_size;
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150601/9f4777fc/attachment.html>


More information about the lldb-commits mailing list