[Lldb-commits] [PATCH] Change dosep to report pass/failure of individual test cases as well.

Zachary Turner zturner at google.com
Wed May 27 14:44:03 PDT 2015


Doh, sorry about that. Pretend you didn't see that, I'll get it out
tomorrow
On Wed, May 27, 2015 at 2:42 PM Greg Clayton <clayborg at gmail.com> wrote:

> Looks like some windowns specific code was left in dosep.py:
>
>   import ctypes
>   from ctypes import wintypes
>
>   _OutputDebugString = ctypes.windll.kernel32.OutputDebugStringA
>   _OutputDebugString.argtypes = [wintypes.LPCSTR]
>   _OutputDebugString.restype = None
>
>
> ================
> Comment at: test/dosep.py:33-39
> @@ -32,2 +32,9 @@
>
> +import ctypes
> +from ctypes import wintypes
> +
> +_OutputDebugString = ctypes.windll.kernel32.OutputDebugStringA
> +_OutputDebugString.argtypes = [wintypes.LPCSTR]
> +_OutputDebugString.restype = None
> +
>  from optparse import OptionParser
> ----------------
> Doesn't this only need to be done on windows? Shouldn't you check for
> platform being windows?
>
> http://reviews.llvm.org/D10068
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150527/4b74f53a/attachment.html>


More information about the lldb-commits mailing list