[Lldb-commits] [PATCH] Allow both MSVC and Itanium mangling schemes.
chaorenl at google.com
Tue May 26 15:20:12 PDT 2015
Yeah, the the entire thing didn't compile on Windows before. Virgile Bello
tried to add these in r205769 but was reverted by emaste in r205776 since
it broke FreeBSD. I put these here because I think it's nicer to have
minimal changes to the cxa_demangler copy.
On Tue, May 26, 2015 at 3:15 PM, Zachary Turner <zturner at google.com> wrote:
> I mean I see
> +#define noexcept
> +#define constexpr
> +#define snprintf _snprintf
> +#define alignas(X) __declspec(align(X))
> but I dont' see corresponding -'s from anywhere else in the diff. So it
> looks like this is new code, not moved from somewhere else. Unless I'm
> just missing something. But now that I think about it, it looks like it's
> just because all this was previously compiled out on Windows, and now it's
> being compiled on Windows.
> Since we've inlined a copy of the code already anyway, personally I don't
> see anything wrong with making small changes like this just to get it to
> compile on all platforms. I mean I wouldn't think it wise to change some
> of the actual logic of the demangling, but just adding decorators on
> functions to get it to compile would be ok I would think? Others may
> disagree though :)
> EMAIL PREFERENCES
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits