[Lldb-commits] [PATCH] Enable workaround for finding functions in global namespace on linux binaries on all hosts.

[Zachary Turner]

If it's not correct in the object file I think the best fix is to make it
correct in the object file.  I actually had to fix a few things like that
in the past.  Either way, don't worry about it.  I will get around to it
eventually :)  Maybe a comment saying // TODO: The arch in the object file
isn't correct for MSVC binaries on windows, so we should find a way to make
it correct.

On Thu, May 14, 2015 at 2:05 PM Robert Flack <flackr at gmail.com> wrote:

> REPOSITORY
>   rL LLVM
>
> ================
> Comment at:
> lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4054-4055
> @@ -4054,4 +4053,4 @@
>                              ConstString demangled_name =
> sc.GetFunctionName(Mangled::ePreferDemangled);
>                              if (strncmp(mangled_name.GetCString(), "_ZN",
> 3) ||
>                                  !strncmp(demangled_name.GetCString(),
> "(anonymous namespace)", 21))
>                              {
> ----------------
> zturner wrote:
> > This check is only meaningful under a particular ABI.  Could you check
> the triple or ArchSpec of the target you're looking at first, and either
> not do this if the triple contains MSVC (or better yet, add a correct
> check)?
> Hey, I added a check that the object file is linux or freebsd:
> http://reviews.llvm.org/D9782. I tried to add a check for windows arch as
> well, but the arch was not correctly recognized in my tests, I was seeing
> i386-unknown-unknown. Let me know if you know where I might be able to find
> the target arch instead if not through the object file and I'm happy to add
> a correct Windows check as well. Thanks.
>
> http://reviews.llvm.org/D9754
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150514/3e7b94f5/attachment.html>