[Lldb-commits] [lldb] r237089 - TestPublicAPIHeaders.py - Changed expectedFailureDarwin to skipIfDarwin

[Tamas Berghammer]

Hi Vince,

Can you put back the @expectedFailure decorator next to the @skipIfDarwin
decorator? Having both will have the same effect as @skipIfDarwin only but
makes it easier when we grep for XFAIL-s (we do it for several test case
which times out on the Linux build bot).

Thanks,
Tamas

On Tue, May 12, 2015 at 6:18 AM, Vince Harron <vince at nethacker.com> wrote:

> Author: vharron
> Date: Tue May 12 00:18:06 2015
> New Revision: 237089
>
> URL: http://llvm.org/viewvc/llvm-project?rev=237089&view=rev
> Log:
> TestPublicAPIHeaders.py - Changed expectedFailureDarwin to skipIfDarwin
>
> expectedFailure doesn't work if the failure is in a teardown step.
>
>
> Modified:
>     lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py
>
> Modified:
> lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py?rev=237089&r1=237088&r2=237089&view=diff
>
> ==============================================================================
> --- lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py
> (original)
> +++ lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py
> Tue May 12 00:18:06 2015
> @@ -21,7 +21,8 @@ class SBDirCheckerCase(TestBase):
>          self.exe_name = 'a.out'
>
>      @skipIfNoSBHeaders
> -    @expectedFailureDarwin # test passes but teardown command 'settings
> remove target.env-vars DYLD_LIBRARY_PATH' fails
> +    @skipIfDarwin # test passes but teardown command 'settings remove
> target.env-vars DYLD_LIBRARY_PATH' fails
> +    # (expectedFailureDarwin doesn't work for teardown failures)
>      def test_sb_api_directory(self):
>          """Test the SB API directory and make sure there's no unwanted
> stuff."""
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150512/bf3e042a/attachment.html>