[Lldb-commits] [lldb] r236870 - Remove check for object file type from DynamicLoaderPOSIXDYLD::DidAttach

Tamas Berghammer tberghammer at google.com
Fri May 8 08:45:53 PDT 2015


Author: tberghammer
Date: Fri May  8 10:45:53 2015
New Revision: 236870

URL: http://llvm.org/viewvc/llvm-project?rev=236870&view=rev
Log:
Remove check for object file type from DynamicLoaderPOSIXDYLD::DidAttach

For PIE executables the type of the main executable is shared object
so we can't force that the main executable should have the type of
executable.

Modified:
    lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

Modified: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp?rev=236870&r1=236869&r2=236870&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp (original)
+++ lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp Fri May  8 10:45:53 2015
@@ -140,10 +140,6 @@ DynamicLoaderPOSIXDYLD::DidAttach()
         lldb_private::ObjectFile * obj = executable_sp->GetObjectFile();
         if (obj)
         {
-            // don't rebase if the module is not an executable
-            if (obj->GetType() != ObjectFile::Type::eTypeExecutable)
-                rebase_exec = false;
-
             // don't rebase if the module already has a load address
             Target & target = m_process->GetTarget ();
             Address addr = obj->GetImageInfoAddress (&target);





More information about the lldb-commits mailing list