[Lldb-commits] [PATCH] Fix handling of hijacked events in synchronous mode

[jingham at apple.com]

I don't understand this.  The Command line worked just fine and informed the user about stops without this extra event being generated.  Why does the MI need what the command line doesn't?

Jim


> On May 8, 2015, at 8:19 AM, Ilia K <ki.stfu at gmail.com> wrote:
> 
> In http://reviews.llvm.org/D9371#169036, @jingham wrote:
> 
>> The more serious question I had with this patch was that it looks like this change means you are now generating a stop event when you do a synchronous continue.  I don't think anybody is expecting synchronous continues to generate events.  Why is this not a problem?
> 
> 
> These events are needed by lldb-mi to print *stopped notification. It always should print them in both async and sync mode, like it GDB does:
> 
>  $ gdb --interpreter=mi hello
>  [...]
>  -gdb-set target-async off
>  ^done
>  (gdb)
>  -gdb-show target-async
>  ^done,value="off"
>  (gdb)
>  -break-insert -f main
>  ^done,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0x00401442",func="main(int, char**)",file="hello.cpp",fullname="c:\\p\\tests\\hello.cpp",line="46",thread-groups
>  =["i1"],times="0",original-location="main"}
>  (gdb)
>  -exec-run
>  [...]
>  *stopped,reason="breakpoint-hit",disp="keep",bkptno="1",frame={addr="0x00401442",func="main",args=[{name="argc",value="1"},{name="argv",value="0x32520"}],file="hello.cpp",fullname="c:
>  \\p\\tests\\hello.cpp",line="46"},thread-id="1",stopped-threads="all"
>  (gdb)
>  -break-insert hello.cpp:48
>  ^done,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="0x00401476",func="main(int, char**)",file="hello.cpp",fullname="c:\\p\\tests\\hello.cpp",line="48",thread-groups
>  =["i1"],times="0",original-location="hello.cpp:48"}
>  (gdb)
>  -exec-continue
>  [...]
>  *stopped,reason="breakpoint-hit",disp="keep",bkptno="2",frame={addr="0x00401476",func="main",args=[{name="argc",value="1"},{name="argv",value="0x32520"}],file="hello.cpp",fullname="c:
>  \\p\\tests\\hello.cpp",line="48"},thread-id="1",stopped-threads="all"
>  (gdb)
> 
> 
> http://reviews.llvm.org/D9371
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
>