[Lldb-commits] [PATCH] Skip sysroot creation by module cache if symbolic links are not allowed for active user.

[Zachary Turner]

Hmm, yea that's not a bad idea. Let me look into the privilege thing a
little tomorrow. In the meantime, do we properly handle the error case
anyway (at least it should print a log and not have unexpected behavior).
Creating the symlink could fail on other platforms too, not just windows
On Thu, May 7, 2015 at 5:28 PM Oleksiy Vyalov <ovyalov at google.com> wrote:

> In http://reviews.llvm.org/D9587#168485, @zturner wrote:
>
> > Even with this check, creating the symbolic link might still fail for
> other reasons related to the filesystem and not related to security.  Would
> it be better to just try to create it no matter what and log the error if
> it fails?
>
>
> I believe calling EnableCreateSymLinkPrivilege might be beneficial anyway
> since as I can tell from running "whoami /priv" that
> SE_CREATE_SYMBOLIC_LINK_NAME is disabled by default . I'm somewhat
> concerned that we may call FileSystem::Symlink when we 100% confident that
> it will fail. As an alternative, we may just call FileSystem::Symlink
> anyway but always ignoring its result...
>
> Please let me know your opinion.
>
>
> http://reviews.llvm.org/D9587
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150508/8c7beaaf/attachment.html>