[Lldb-commits] [PATCH] Don't call the Process::SyncIOHandler in Target::Launch

[Ilia K]

>RE: Is change this necessary to ensure correctness, or is it just a matter
of saving some lines of code?
It was done to ensure correctness because Target::Launch consists of ~4
branches of code where it was needed and it was to difficult to maintain.
In addition it is needed only for lldb to ensure that event is handled
before printing of (lldb) prompt, but if it doesn't matter when we using a
public API (i.e. SBTarget::Launch).
And the last benefit is to remove the duplicated code.

>RE: It's not clear to me why is this the case, but the test takes ~6
minutes now, where previously it took slightly less than 5.
I think it is a matter of TestMiStartupOptoins failure because each test is
waiting ~30sec before failing.

Thanks,
Ilia
On May 7, 2015 4:40 PM, "Pavel Labath" <labath at google.com> wrote:

> Is change this necessary to ensure correctness, or is it just a matter of
> saving some lines of code?
>
> I am asking this because, this change has increased the running time of
> the test suite (compare
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/2252
> with
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/2251),
> sending TestConcurrentEvents over the 5m limit on the linux build bot. It's
> not clear to me why is this the case, but the test takes ~6 minutes now,
> where previously it took slightly less than 5. For now I have increased the
> timeout limit to address this, but we will need to do something different
> in the future.
>
>
> http://reviews.llvm.org/D9373
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150507/df2bce38/attachment.html>